#372 Add Slug to Protip URLs for SEO #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need tests for this. |
|
Could you rebase and squash you commits ? The tests are passing in master now. |
29219c2 to
4932429
Compare
c6efe41 to
e049845
Compare
just3ws
added a commit
that referenced
this pull request
Nov 3, 2014
#372 Add Slug to Protip URLs for SEO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies protip public_ids to be SEO friendly slugs and copies existing shortcodes to a new shortcode column.
Run: 'rake generate_protip_slugs' after db:migrate to generate new slugs