[WIP] Join team error #391 #229
Conversation
|
Thank you @YaroSpace , could you please squash the commits ? |
|
sure, to how many - one? |
|
No, always by context. I see 3 context there (refactoring, fix and added specs) and YMMV. |
|
@just3ws |
once 💚|
Thanks you @YaroSpace |
|
@seuros, np at all. any other comments to cleanup the PR? |
|
I'm getting 500 errors because the path is being formatted as "http://localhost:3000/teams?team%5Bselected%5D=true&team%5Bslug%5D=xxx" |
|
Arghh....found the bug. It is not the path formatting (it is a valid encoding of nested params %5B='[' and %5D=']'), but something else that I managed to overlook both in code and specs. I am very sorry about this, will fix asap. |
|
You’re correct, I misread the error. I didn’t get a chance to work through the entire issue but there was another error about missing attributes. :( I think it was name. On October 22, 2014 at 6:36:12 PM, Yaro (notifications@github.com) wrote: Weird. Are you sure it is because of this? It is a valid encoding of nested params %5B='[' and %5D=']' and we always had it in app/views/teams/_similar_teams.html.haml:15 prior to my changes. — |
split rendering similar teams into a separate template refactored #creare and added specs refactored #exact_team_exists? and added specs added shared notification_bar partial and linked to product_description layout added showing notifications on team creation
added specs for success/filure notifications
|
Fixed the bug. But please hold until I add the feature specs. |
|
please squash commits |
|
nevermind, i had outdated page, i had to refresh. |
|
Awesome @YaroSpace thanks! |
This PR is waiting for feature specs to be added
Fix for Error when attempting to join a team instead of create a team #391
The fix was a one liner - incorrect format of params, which caused
params.permitto raise a 400 error.I covered the related logic with specs and also did a little refactoring to make it easier to test and to understand the logic.
Changes:
#with_similar_namesto Team model method