Skip to content

#408 Adding heroku_deflater gem to append gzipped asset locations #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2014
Merged

#408 Adding heroku_deflater gem to append gzipped asset locations #233

merged 1 commit into from
Nov 4, 2014

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Oct 24, 2014

@YaroSpace
Copy link
Contributor

@just3ws @seuros I have seen this spec failing on Travis a few times now, maybe we should create a bounty and fix it?

@seuros
Copy link
Contributor

seuros commented Oct 27, 2014

There is a failing test.

 1) Protip protip wrapper handles link only protips

Failure/Error: expect(wrapper.only_link?).to eq(link_protip.only_link?)

NoMethodError:

undefined method `[]' for nil:NilClass

# ./app/models/protip/search_wrapper.rb:42:in `only_link?'

# ./spec/models/protip_spec.rb:185:in `block (3 levels) in <top (required)>'

just3ws added a commit that referenced this pull request Nov 4, 2014
@just3ws
Merge pull request #233 from bjfish/gzip_assets
32bec64 
#408 Adding heroku_deflater gem to append gzipped asset locations
@just3ws just3ws merged commit 32bec64 into coderwall:master Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjfish @YaroSpace @seuros @just3ws