Join team error #391 #234
Merged
Join team error #391 #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,3 +57,4 @@ git_stats | |||
| vcr_cassettes | |||
| dump | |||
| BACKUP | |||
| Guardfile | |||
There was a problem hiding this comment.
I think it is worth adding those, so that devs can have their own local settings. Or is there a better way of doing this?
fix for ajax validations wihtout parameter create logig refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reabased against current master, so it will fix any issues introduced by previous PRs on this bounty
Fix for Error when attempting to join a team instead of create a team #391
The fix was a one liner - incorrect format of params, which caused
params.permitto raise a 400 error.I covered the related logic with specs and features and also did a little refactoring to make it easier to test and to understand the logic.
Changes:
:show_similarand:join_teamto clarify user intentions#with_similar_namesto Team model methodUsernamesControllerwhen validation is run against an empty user namepoltergeistheadless browser for integration testing with feature specs (will requirephantomjsexecutable to be added to the vagrant box)