Skip to content

Fixed joining networks from networks list pages #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2014

Conversation

Mileshosky
Copy link
Contributor

WIP #39
https://assemblymade.com/coderwall/wips/39

Networks cannot be joined in production due to an improperly formed href value on the Join button/link.

  • Removed improper caching from networks/_alphabetized_list partials.
  • Also adjusted the width of the header for aesthetics on networks list pages

Caching of the _alphabetized_list partial would cache and display improper html that was inappropriate for logged in users vs non logged in users. This causes joining a network to be broken currently for logged in users.

I have removed the caching entirely from the partial for 2 reasons:

  • There are ~70 Networks at the moment, so caching is not entirely necessary at the moment.
  • The controller action is pulling Network.all from cache anyways. Caching the sorted partial seems overkill right now, especially considering it's breaking Join/Leave in production

I also took the opportunity to widen the navigation header in the Networks list pages, I think it looks better:

Before:
networks-header

After:
networks-full-width

Also adjusted the width of the header for aesthetics on networks
list pages
just3ws added a commit that referenced this pull request Jun 26, 2014
Fixed joining networks from networks list pages
@just3ws just3ws merged commit 8458d57 into coderwall:master Jun 26, 2014
@Mileshosky Mileshosky deleted the join-networks-39 branch June 27, 2014 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants