Skip to content

Bounty #455 - Fix User#on_team? #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2014

Conversation

jakegavin
Copy link
Contributor

https://assembly.com/coderwall/bounties/455

Currently the welcome email checks if @user.on_team? and then if they are presents some info referencing @user.team https://github.com/assemblymade/coderwall/blob/master/app/views/notifier_mailer/welcome_email.html.haml#L20
User#on_team? previously checked for team_document_id. I talked with @seuros who told me that team_document_id is deprecated and will be removed, and that we're temporarily using team_id until support for belonging to multiple teams is added.

I've updated User#on_team? to check if a user has a team_id or a membership. I also updated User#team so that it returns the team associated with the membership (but also still supports associating teams by team_id).

This is my first PR on this project and this is one of the larger, more complex projects I've worked on so let me know if there is anything I should be doing differently.

just3ws added a commit that referenced this pull request Dec 14, 2014
@just3ws just3ws merged commit 2ae3e6f into coderwall:master Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants