Bounty #455 - Fix User#on_team? #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://assembly.com/coderwall/bounties/455
Currently the welcome email checks if
@user.on_team?
and then if they are presents some info referencing@user.team
https://github.com/assemblymade/coderwall/blob/master/app/views/notifier_mailer/welcome_email.html.haml#L20User#on_team?
previously checked forteam_document_id
. I talked with @seuros who told me thatteam_document_id
is deprecated and will be removed, and that we're temporarily usingteam_id
until support for belonging to multiple teams is added.I've updated
User#on_team?
to check if a user has ateam_id
or amembership
. I also updatedUser#team
so that it returns the team associated with themembership
(but also still supports associating teams byteam_id
).This is my first PR on this project and this is one of the larger, more complex projects I've worked on so let me know if there is anything I should be doing differently.