Remove with_username completely
#270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,23 +126,13 @@ def near | |||
| #TODO Kill | |||
| scope :username_in, ->(usernames) { where(["UPPER(username) in (?)", usernames.collect(&:upcase)]) } | |||
|
|
|||
| #TODO Kill | |||
| def self.with_username(username, provider = :username) | |||
| def self.from_elsewhere_username(username, provider='') | |||
There was a problem hiding this comment.
can we think about another method name ? also provider is not optional in this case.
There was a problem hiding this comment.
can we think about another method name ?
Sure, find_by_external_username?
provider is not optional in this case.
True, let me change that.
7eb5508 to
22849e5
Compare
|
Travis failed due to a connection timeout, so I closed and opened the PR to restart the build. |
22849e5 to
f9ef19d
Compare
seuros
added a commit
that referenced
this pull request
Dec 26, 2014
Remove `with_username` completely
seuros
pushed a commit
to seuros/coderwall
that referenced
this pull request
Mar 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://assembly.com/coderwall/bounties/479
This PR replaces the
with_usernamefunction withfind_by_usernamewhen it searches only by the internal username (coderwall username), and withfrom_elsewhere_usernamewhen it searches by an external username.