Skip to content

Minor version bump to sass to get it working with windows. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2014

Conversation

RexMorgan
Copy link
Contributor

Vagrant on windows was throwing errors while compiling the files with sass. This is a minor version bump that Mike Hall helped me with to get it working properly.

@akosednar
Copy link
Contributor

That error is from the NFS sync folders. Did you try it with the code after pull req #22

Sent from my iPhone

On Jun 26, 2014, at 3:53 PM, Rex Morgan notifications@github.com wrote:

Vagrant on windows was throwing errors while compiling the files with sass. This is a minor version bump that Mike Hall helped me with to get it working properly.

You can merge this Pull Request by running

git pull https://github.com/RexMorgan/coderwall upgrade-sass
Or view, comment on, or merge it at:

#28

Commit Summary

Minor version bump to sass to get it working with windows.
File Changes

M Gemfile (2)
M Gemfile.lock (6)
Patch Links:

https://github.com/assemblymade/coderwall/pull/28.patch
https://github.com/assemblymade/coderwall/pull/28.diff

Reply to this email directly or view it on GitHub.

@RexMorgan
Copy link
Contributor Author

@akosednar Yes, I updated the code to the lastest on master (which included #22 ) and still had issues getting it working.

Bumping up the version of sass-rails fixed the issue.

I can reproduce the issue, by checking out master and getting this error:
image

Once I checkout my branch, it works.

@akosednar
Copy link
Contributor

You sure the branch with #22 was checked out? The screenshot you have attached shows the cache generating in /home/vagrant/web instead of /tmp/codewall-tmp/

@akosednar
Copy link
Contributor

Weird. Sorry just curious!

Sent from my iPhone

On Jun 26, 2014, at 4:18 PM, Rex Morgan notifications@github.com wrote:

@akosednar Yes, I updated the code to the lastest on master (which included #22 ) and still had issues getting it working.

Bumping up the version of sass-rails fixed the issue.


Reply to this email directly or view it on GitHub.

@just3ws
Copy link
Contributor

just3ws commented Jun 27, 2014

The upgrade was a fix for a file sync issue on windows but didn't have any noticeable negative effect on existing CSS assets. There's a good SO article with more explanation regarding the error,

Sent from my iPhone

On Jun 26, 2014, at 7:08 PM, Anthony Kosednar notifications@github.com wrote:

Weird. Sorry just curious!

Sent from my iPhone

On Jun 26, 2014, at 4:18 PM, Rex Morgan notifications@github.com wrote:

@akosednar Yes, I updated the code to the lastest on master (which included #22 ) and still had issues getting it working.

Bumping up the version of sass-rails fixed the issue.


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

@RexMorgan
Copy link
Contributor Author

I just double checked and in app/environments/development.rb it looks like your changes are there. But it's still causing the issue. I saw that the paths weren't correct, also and thought that was strange. I should also note that I'm using a fairly old version of virtualbox. (4.2.16 r86992).

I'm going to attempt to upgrade that to the latest version and see if maybe that's what's causing the issue.

@just3ws
Copy link
Contributor

just3ws commented Jun 27, 2014

Yeah, definitely want to have a recent vbox and vagrant installed.

Sent from my iPhone

On Jun 26, 2014, at 8:22 PM, Rex Morgan notifications@github.com wrote:

I just double checked and in app/environments/development.rb it looks like your changes are there. But it's still causing the issue. I saw that the paths weren't correct, also and thought that was strange. I should also note that I'm using a fairly old version of virtualbox. (4.2.16 r86992).

I'm going to attempt to upgrade that to the latest version and see if maybe that's what's causing the issue.


Reply to this email directly or view it on GitHub.

@RexMorgan
Copy link
Contributor Author

Just installed the latest virtual box, I just downloaded and installed vagrant last night, so it's up to date, and I'm still getting the issues.

@akosednar If you'd like to do a screen share and take a look at my code to ensure that I'm not crazy, I have no issues with that. I'm pretty new to ruby and rails, so I could just be missing something. I'm rex.morgan at gmail on Screenhero.

@zavg
Copy link

zavg commented Jun 27, 2014

+1
I have experienced just the same issue with actual versions of vagrant and virtualbox.
And patch proposed by @RexMorgan fixes it.

@akosednar
Copy link
Contributor

Wonder why it worked with the previous patch on other instances. Weird but okay! 👍

just3ws added a commit that referenced this pull request Jun 29, 2014
Minor version bump to sass to get it working with windows.
@just3ws just3ws merged commit e30bd2b into coderwall:master Jun 29, 2014
@RexMorgan RexMorgan deleted the upgrade-sass branch June 29, 2014 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants