Skip to content

Fix 404 pages #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2015
Merged

Fix 404 pages #283

merged 1 commit into from
Jan 5, 2015

Conversation

rohitpaulk
Copy link
Contributor

Bounty#492

ActionView::MissingTemplate: Missing template errors/not_found with {:locale=>[:en], :formats=>[:png], :handlers=>[:erb, :builder, :slim, :jbuilder, :coffee, :haml]}. Searched in: * "/app/app/views" * "/app/vendor/bundle/ruby/2.1.0/gems/kaminari-0.16.1/app/views"

Currently, a 404 only responds to html, json and xml. This should respond to all formats.

This error has occurred 21744 times till now.

@rohitpaulk rohitpaulk force-pushed the fix-404-page branch 5 times, most recently from 377b539 to 19c9a13 Compare January 4, 2015 08:57
Bounty#492
@rohitpaulk rohitpaulk changed the title Fix bounty pages Fix 404 pages Jan 4, 2015
@seuros
Copy link
Contributor

seuros commented Jan 4, 2015

Tests ?

@rohitpaulk
Copy link
Contributor Author

@seuros - The tests I tried to add were failing for reasons I haven't been able to clearly debug till now - looks like there's a conflict somewhere in setting consider_all_requests_local and action_dispatch.show_exceptions.

The tests were skipped until now, guess they'll get cleaned up as a part of Bountry #464.

@seuros
Copy link
Contributor

seuros commented Jan 4, 2015

👍

seuros added a commit that referenced this pull request Jan 5, 2015
@seuros seuros merged commit 7e5c886 into coderwall:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants