Skip to content

remove existing changeLog'd API integration - Bounty #488 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2015
Merged

remove existing changeLog'd API integration - Bounty #488 #288

merged 1 commit into from
Jan 10, 2015
+2 −105

Conversation

codebender
Copy link
Contributor

Remove the ChangeLog API integration

  • remove existing api integration
  • support existing badges

seuros added a commit that referenced this pull request Jan 10, 2015
@seuros
Merge pull request #288 from codebender/remove_change_log
e3779ac 
remove existing changeLog'd API integration - Bounty #488
@seuros seuros merged commit e3779ac into coderwall:master Jan 10, 2015
@seuros
Copy link
Contributor

seuros commented Jan 10, 2015

This caused RuntimeError: NOT IMPLEMENTED

/app/models/badges/badge_base.rb:60 in "award?"
/app/models/badges/badge_base.rb:22 in "block in award!"
/app/models/badges/badge_base.rb:21 in "select"
/app/models/badges/badge_base.rb:21 in "award!"
/app/models/user.rb:447 in "check_achievements!"
/app/jobs/refresh_user_job.rb:14 in "perform"

@rohitpaulk
Copy link
Contributor

Yes, and it's blocking new signups.

@seuros seuros mentioned this pull request Jan 10, 2015
Merged
@seuros
Copy link
Contributor

seuros commented Jan 10, 2015

reverted!

@codebender
Copy link
Contributor Author

@seuros @rohitpaulk looks like I need to add back the award? method and return false. I was trying to get a sense from other badges that are no longer awardable.

seuros pushed a commit to seuros/coderwall that referenced this pull request Mar 1, 2015
@carlwoodward
Fix coderwall#288 - add provider user lookup.
0b5e44f 
- Add controller to pick up /providers/:provider/:username.
- Add service to look up user by provider.
seuros pushed a commit to seuros/coderwall that referenced this pull request Mar 1, 2015
@just3ws
Merge pull request coderwall#207 from carlwoodward/288-provider-user-…
8113cb4 
…lookup

Fix coderwall#288 - add provider user lookup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebender @seuros @rohitpaulk