Fix new subscriptions #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| validates_presence_of :stripe_card_token | ||
| validates_presence_of :stripe_customer_token | ||
| validates :team_id, presence: true, uniqueness: true | ||
| validate :admin_id, :payer_is_team_admin |
9e70757 to
63e48b4
Compare
|
@rohitpaulk could you squash your commits by context ? |
Reorganize Plan model, Remove duplicated uniqueness validations, Fix seeds.rb Regression from coderwall#279, Remove payer_is_team_admin
Strong Parameters for account params Fix if condition in save_with_payment When save_with_payment is called, stripe_customer_token might not be available, so we should check for just stripe_card_token.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bounty#500
I've made the commits small and verbose for reviewing purposes. I'll squash and reword them once this is reviewed.