Skip to content

Fix user specs #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2015
Merged

Fix user specs #294

merged 2 commits into from
Jan 12, 2015

Conversation

rohitpaulk
Copy link
Contributor

Bounty#504

  • fixed tests for find_by_username
  • reordered the user model specs and grouped them meaningfully.
  • Move the sample OAuth responses into separate JSON files

chrislloyd added a commit that referenced this pull request Jan 12, 2015
@chrislloyd
Merge pull request #294 from rohitpaulk/fix-user-specs
84ec222 
Fix user specs
@chrislloyd chrislloyd merged commit 84ec222 into coderwall:master Jan 12, 2015
@rohitpaulk rohitpaulk deleted the fix-user-specs branch January 15, 2015 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitpaulk @chrislloyd