Improve the tag inputs when creating a protip #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protips edit page to provide enhanced tagging interface. Bounty #490
seuros
added a commit
that referenced
this pull request
Apr 28, 2015
Improve the tag inputs when creating a protip
|
I just tested this in prod and it looks like I forgot the CSS. When I try to add a tag, it stays plaintext and kicks to a newline. Can someone confirm? @seuros I can put up a new pr to fix this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add selectize.js to Gemfile, and attach selectize to topic_list field on Protips edit page to provide enhanced tagging interface.
Moving the placeholder to the selectize function also fixes an issue where you can save an empty protip in production and it saves with the tags of "Tags" and "comma separated"
One previous attempter said there were structural issues, but I don't know what that means. The only minor roadblock I found is trying to move the error hover if you try to submit a protip without a tag. Let me know if you have an idea how to correct that.
Bounty #490