Skip to content

Prevent page caching during the account deletion process. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

vergilet
Copy link
Contributor

Fixing the issue when a user tries to delete his account, but doesn't see confirmation alert.

The problem is that the application renders cached version of the page on the second step of account deletion process (the application always shows cached first step).
Excluded Account Deletion Section from rails cache.

@vergilet
Copy link
Contributor Author

Hi, @whatupdave.
I see that tests on Travis CI didn't pass here. I believe it is not something related to my changes.
Anyway you can merge the pull request.
Let me know if you want me to fix Travis CI.

@whatupdave
Copy link
Contributor

Verified, looks good, thanks!

@whatupdave whatupdave merged commit b5e62f8 into coderwall:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants