Rename BaseLoginForm.get_context to avoid clash with Django internals
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Django 4.0 `forms.Form.get_context` was introduced for passing form context in templates. https://docs.djangoproject.com/en/4.0/ref/forms/api/#django.forms.Form.get_context Due to this we have a clash, as django-mail-auth uses function with the same name, but for different purpose: ```python BaseLoginForm.get_context() missing 2 required positional arguments: 'request' and 'user' ```
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 331 331
=========================================
Hits 331 331
Continue to review full report at Codecov.
|
codingjoe
approved these changes
Jan 10, 2022
BaseLoginForm.get_context to avoid clash with Django internalsBaseLoginForm.get_context to avoid clash with Django internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Django 4.0
forms.Form.get_contextwas introduced for passing form context in templates.https://docs.djangoproject.com/en/4.0/ref/forms/api/#django.forms.Form.get_context
Due to this change, we have a clash, as django-mail-auth uses a function with the same name, but for different purpose: