Change the stream position after reading in validators #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingjoe
reviewed
Apr 12, 2020
There was a problem hiding this comment.
Thanks again @jeromelebleu another good catch. However, I am not sure if we shouldn't keep the seek(0) and to have it in both places. This will keep it working in case the value has the cursor set wrong from a previous routine. What do you think?
|
I have asked myself this question a long time to finally think that it should already be at the start. But you're probably right, I will re-add it. |
fc3b71f to
c2a3e79
Compare
|
Released in 5.1.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ensures that the image's stream position is always at the start after running validators to prevent issues with further file reading - e.g. another validator which doesn't seek, or another form validation since
seek(0)is called at the end.This fixes an issue that I encounter using Wagtail and StdImageField with size validators. I always have the error Upload a valid image. The file you uploaded was either not an image or a corrupted image. for the image field. I presume
to_python()is called on the field after the form validation. I didn't add a relevant test since it could require too much steps to encounter this issue.