Skip to content

Conversation

gpapakyriakopoulos
Copy link
Contributor

The HTTP headers are optionally requested as a key-value comma separated list, when the user selects GET or POST method (the same way the POST body parameters are requested).

All requests then include the user supplied headers. All requests are now made with urllib2 instead of urllib to support header input.

Also fixed a minor bug where no URL parameters with GET method would results in an AttributeError Exception

Have tested all except DBInfo() which should be tested against an actual MongoDB instance.

tcstool added a commit that referenced this pull request May 22, 2015
Modified main functionality to also allow HTTP headers for inclusion in web application requests.
@tcstool tcstool merged commit c65fc79 into codingo:0.5 May 22, 2015
@tcstool
Copy link
Collaborator

tcstool commented May 22, 2015

Excellent changes, these will be the last for 0.7. Thanks for the contribution! Please continue to help and suggest improvements.

@gpapakyriakopoulos gpapakyriakopoulos deleted the add_http_headers branch May 22, 2015 14:34
@gpapakyriakopoulos
Copy link
Contributor Author

Will do, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants