feat: enhance signoff check by adding message body and a better regex #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of signoff policy check is considering only the subject. This is wrong because the signoff line is added in the body of a commit message. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
This name of the function is actualy wrong because it fetches only one single commit. I also added a sha parameter to help in the future to fetch older commits from the tree. Then, we can analyse multiple commits as the original function name suggests. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
Before this commit, the signoff regex only looks for the exact word. This new proposal also checks if the commit has an email associated to it. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
This commit just updates the command line that is called by `get_commit_info` to reflect the latest changes. Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
shenxianpeng
approved these changes
Mar 10, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 98.00% 98.01% +0.01%
==========================================
Files 7 7
Lines 250 252 +2
==========================================
+ Hits 245 247 +2
Misses 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds some enhancements in commit-check code such as:
get_commits_infoplus add the hash to verify it. In the future, it should be nice to check a range of commits and not only the HEAD. That's why this function was rebased a little bit to match what is exactly doing today.