Skip to content

fix: update .commit-check.yml #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix: update .commit-check.yml #104

merged 1 commit into from
Feb 24, 2025

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Feb 24, 2025 •
edited by coderabbitai bot
Loading

Ref commit-check/commit-check#221

Summary by CodeRabbit

  • Chores
    • Enhanced the validation for contributor names to now support a broader range of international characters, including accented and extended Unicode characters.

@shenxianpeng shenxianpeng added the bug Something isn't working label Feb 24, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2025 •
edited
Loading

Walkthrough

The change updates the regular expression in the .commit-check.yml file to support accented and additional Unicode characters in author names. The new regex broadens the validation while preserving the original commit check functionality. Exported or public entity declarations remain unchanged.

Changes

File(s) Change Summary
.commit-check.yml Modified the regex for author name validation to include accented characters and extra Unicode ranges.

Poem

I'm a tiny rabbit with a coding flair,
Hopping through regex with style to spare.
Accents and Unicode now dance in the night,
Making commit checks friendly and bright.
With each new line, I cheer with delight! 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

Commit-Check ✔️

coderabbitai[bot]
coderabbitai bot reviewed Feb 24, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.commit-check.yml (1)

17-21: Enhanced Regex for author_name: Great expansion to support accented and extended Unicode characters.
The updated regex

^[A-Za-zÀ-ÖØ-öø-ÿ\u0100-\u017F\u0180-\u024F ,.\'-]+$|.*(\[bot])

now allows for a broader spectrum of characters, which improves internationalization support. As a suggestion, for consistency with the other checks (e.g., the commit message regex on line 4), consider enclosing this regex in quotes. This can help avoid potential YAML parsing ambiguities.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec47d19 and 5e66953.

📒 Files selected for processing (1)
  • .commit-check.yml (1 hunks)
🔇 Additional comments (1)
.commit-check.yml (1)

1-16: YAML Integrity Check: All other commit checks are structured correctly.
The file’s YAML structure is consistent and the validation patterns for commit messages, branch naming, author email, and merge base remain unchanged. No further issues found in these sections.

Also applies to: 22-31

@shenxianpeng shenxianpeng merged commit cac2d49 into main Feb 24, 2025
4 checks passed
@shenxianpeng shenxianpeng deleted the patch-1 branch February 24, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shenxianpeng