Skip to content

Relax specification for argcomplete dependency #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakob-keller opened this issue Sep 17, 2022 · 3 comments · Fixed by #589
Closed

Relax specification for argcomplete dependency #588

jakob-keller opened this issue Sep 17, 2022 · 3 comments · Fixed by #589
Labels
type: feature A new enhacement proposal

Comments

@jakob-keller
Copy link
Contributor

Description

Commitizen currently requires argcomplete ^1.12.1, which officially supports Python 3.5-3.9.

argcomplete 2.0 is available, which adds support for Python 3.10 and drops support for Python 3.5 (see CHANGES).

To allow for use of argcomplete 2.0.x in commitizen enabled projects, its dependency specification needs to be relaxed.

Possible Solution

Modify pyproject.toml:

Old:

argcomplete = "^1.12.1"

New

argcomplete = ">=1.12.1,<2.1"

I will prepare a trivial PR.

Additional context

No response

Additional context

No response
@jakob-keller jakob-keller added the type: feature A new enhacement proposal label Sep 17, 2022
@jakob-keller jakob-keller mentioned this issue Sep 17, 2022
Merged
4 tasks
@sshishov
Copy link

sshishov commented Apr 8, 2023

Can we add the support for argcomplete 3.0+?

@jakob-keller jakob-keller mentioned this issue Apr 11, 2023
Merged
4 tasks
@jakob-keller
Copy link
Contributor Author

Can we add the support for argcomplete 3.0+?

#702 should adress this

@sshishov
Copy link

Thanks @jakob-keller , can confirm it is fixed now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new enhacement proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax specification for argcomplete dependency
2 participants
@sshishov @jakob-keller