-
-
Notifications
You must be signed in to change notification settings - Fork 281
/bin/sh
not on Windows
#602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Substituting the portable shebang works. However, |
Hi @adam-grant-hendry , thanks for your report. The html seems to miss some style and barely readable now. Could you guide me through on how to view it correctly? Or could you please share a few example on what you're testing and what's not working even with shebang? |
@adam-grant-hendry are you on vanilla Windows, or do you use WSL or some other *NIX port on Windows? I ask because both format and test scripts are |
I forgot to zip the CSS assets with it, my mistake. I updated the link, so please try downloading and unzipping again. You should see a folder
I use vanilla Windows. The fact the test scripts require that environment is not specified in the Contributing Guide. Rather than switching over to WSL or Cygwin/MSYS, I changed the shebang to a portable variant. My users use Windows, so I develop on Windows (it's easier for me to find problems and help them that way). Regardless, the greater problem is your Windows CI doesn't run. Even if I switched to WSL or Cygwin/MSYS, I have no confidence that Is |
I just saw your test output. Could you please install https://gnupg.org/download/ and see how it works? It seems the doc is outdated. Before we add it to the doc, let's verify whether installing gpg fix it
Ideally, no. We hope this project can be used by all users. |
I installed that and also tested out All tests are now passing in PR #605, so I was able to fix all the errors previously experienced on Windows. Please kindly re-review it at your earliest convenience. Thank you! |
Description
The
pre-commit
scriptstest
andformat
rely on/bin/sh
, which does not exist on Windows (at least the path). This is a non-portable shebang, which can be fixed by using#!/usr/bin/env sh
instead.Steps to reproduce
(a) Fork the repo, install dependencies through
poetry
, and setup thepre-commit
hookspre-commit run --all
Current behavior
On Windows, the
pre-commit
hooksformat
andlinter and test
fail with the error messageExecutable '/bin/sh' not found
.Desired behavior
The
pre-commit
hooks are able to run the provided shell scripts.Screenshots
Environment
Commitizen Version: 2.35.0
Python Version: 3.8.10 (tags/v3.8.10:3d8993a, May 3 2021, 11:48:03) [MSC v.1928 64 bit (AMD64)]
Operating System: Windows
The text was updated successfully, but these errors were encountered: