feat: add check against default branch #1519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93f3c0b to
9627306
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1519 +/- ##
==============================================
Coverage ? 98.28%
==============================================
Files ? 58
Lines ? 2680
Branches ? 0
==============================================
Hits ? 2634
Misses ? 46
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ec2c66 to
3c7623f
Compare
Lee-W
reviewed
Aug 17, 2025
4 tasks
3c7623f to
5232634
Compare
Lee-W
approved these changes
Aug 19, 2025
| @@ -480,3 +480,22 @@ def test_create_commit_cmd_string(mocker, os_name, committer_date, expected_cmd) | |||
| mocker.patch("os.name", os_name) | |||
| result = git._create_commit_cmd_string("", committer_date, "temp.txt") | |||
| assert result == expected_cmd | |||
|
|
|||
|
|
|||
| def test_get_default_branch(mocker: MockFixture): | |||
There was a problem hiding this comment.
This should be separate as 2 test cases instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PR: #1400
Wait for #1472 and #1457
Related issue: #1498
cz check --default-range.Some TODOs
Checklist