Skip to content

Relax specification for argcomplete dependency #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Relax specification for argcomplete dependency #589

merged 1 commit into from
Sep 18, 2022

Conversation

jakob-keller
Copy link
Contributor

Description

Closes #588

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Allow for installation of argcomplete 2.0.x in commitizen enabled projects

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Base: 98.38% // Head: 98.32% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (92b1e89) compared to base (f6ab845).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   98.38%   98.32%   -0.07%     
==========================================
  Files          39       39              
  Lines        1614     1614              
==========================================
- Hits         1588     1587       -1     
- Misses         26       27       +1     
Flag Coverage Δ
unittests 98.32% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/changelog.py 99.43% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lee-W Lee-W requested a review from woile September 18, 2022 03:16
@woile woile merged commit 890bd00 into commitizen-tools:master Sep 18, 2022
@jakob-keller jakob-keller deleted the argcomplete-2 branch September 18, 2022 06:52
@jakob-keller
Copy link
Contributor Author

Thank you, @Lee-W!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax specification for argcomplete dependency
3 participants