Skip to content

Relax specification for argcomplete dependency #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

Relax specification for argcomplete dependency #702

merged 1 commit into from
Apr 27, 2023

Conversation

jakob-keller
Copy link
Contributor

Description

Addresses #588 (comment)

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Allow for installation of argcomplete 3.0.x in commitizen enabled projects

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1153908) 97.42% compared to head (189f8cd) 97.42%.

❗ Current head 189f8cd differs from pull request most recent head 4f28fcf. Consider uploading reports for the commit 4f28fcf to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files          42       42           
  Lines        2022     2022           
=======================================
  Hits         1970     1970           
  Misses         52       52
Flag Coverage Δ
unittests 97.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jakob-keller jakob-keller marked this pull request as ready for review April 11, 2023 09:10
@jakob-keller jakob-keller mentioned this pull request Apr 11, 2023
Closed
@Lee-W Lee-W added the pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check label Apr 23, 2023
@Lee-W Lee-W merged commit aeb5e30 into commitizen-tools:master Apr 27, 2023
@jakob-keller jakob-keller deleted the argcomplete branch April 27, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile woile approved these changes

Assignees
No one assigned
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakob-keller @woile @Lee-W