Skip to content

Option to avoid symlinks #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Option to avoid symlinks #68

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2013

Enables copying of images and files instead of symlinking them to /build if the 'COPY' variable in the user environment is set to true. This helps avoid problems in environments where symlinks aren't applicable. E.g. to use this with component build, one runs COPY=true component build.

@camshaft
Copy link
Contributor

camshaft commented Feb 8, 2013

I would prefer it to be an option passed similar to -d, --development. This way we're not having to mix env vars and options.

@ghost
Copy link
Author

ghost commented Feb 8, 2013

yeah, but what if you want to 'only' use builder e.g. https://github.com/component/builder.js/pull/68/files#L2R173 ?

@ForbesLindesay
Copy link

👍 for functionality 👎 for environment vars. If you want to only use builder, pass builder the option. We already support builder.development() to put it into development mode so just support builder.copyFiles()

@ghost
Copy link
Author

ghost commented Feb 13, 2013

@ForbesLindesay ever pushed a repo with components to github pages?

@ForbesLindesay
Copy link

I'm not sure, what does that have to do with anything. I don't think I've done so with a component that has files like images etc.

I agree we need a way to do it. But it shouldn't be as an environment variable. component-builder is a library, and on the whole you should leave environment variables as an application level thing. Just implement it in the same way as command line flags like --development are implemented in component build

@camshaft
Copy link
Contributor

@ForbesLindesay @kelonye check out #69

@ghost
Copy link
Author

ghost commented Feb 14, 2013

Closing in favor of #69

@ghost ghost closed this Feb 14, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants