Skip to content

DX - 3418 - Added Support for MFA for Login Method and lint issue fix #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 12, 2025
Merged

DX - 3418 - Added Support for MFA for Login Method and lint issue fix #421

merged 7 commits into from
Aug 12, 2025
+361 −32

Conversation

cs-raj
Copy link
Contributor

@cs-raj cs-raj commented Aug 11, 2025

version bump:
1.23.1 -> 1.24.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

Coverage report for commit: ee6c1b6
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ██░░░░░░░░░░░░░░░░░░░░░ │  2.3%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ██████░░░░░░░░░░░░░░░░░ │  9.1%
  80% │ ███████████████████████ │ 40.9%
  90% │ █████████████░░░░░░░░░░ │ 22.7%
 100% │ ███████████████░░░░░░░░ │ 25.0%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 82.34% | Methods: 96.00% | Branches: 68.35%
FilesLinesMethodsBranches
lib
   contentstack.js83.33%100.00%84.62%
   contentstackClient.js83.02%92.86%69.35%
   contentstackCollection.js94.12%100.00%86.67%
   entity.js76.09%100.00%61.33%
lib/core
   Util.js76.70%93.75%61.38%
   concurrency-queue.js69.37%71.43%64.90%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js96.77%100.00%93.65%
   oauthHandler.js88.81%100.00%65.99%
lib/organization
   index.js72.73%100.00%53.09%
lib/organization/teams
   index.js89.47%100.00%65.79%
lib/organization/teams/stackRoleMappings
   index.js78.57%100.00%51.16%
lib/organization/teams/teamUsers
   index.js100.00%100.00%93.75%
lib/query
   index.js73.91%100.00%61.82%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js86.25%100.00%74.00%
lib/stack/auditlog
   index.js91.67%100.00%71.88%
lib/stack/branch
   compare.js68.18%100.00%62.50%
   index.js94.87%100.00%77.78%
   mergeQueue.js83.33%100.00%63.16%
lib/stack/branchAlias
   index.js79.31%100.00%60.98%
lib/stack/contentType/entry
   index.js83.04%100.00%59.29%
lib/stack/contentType/entry/variants
   index.js79.31%100.00%62.86%
lib/stack/contentType
   index.js84.62%100.00%70.13%
lib/stack/deliveryToken
   index.js95.24%80.00%89.47%
lib/stack/deliveryToken/previewToken
   index.js21.43%25.00%14.29%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js93.88%100.00%85.71%
lib/stack/globalField
   index.js91.67%100.00%82.35%
lib/stack
   index.js80.66%92.86%70.61%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/managementToken
   index.js100.00%100.00%94.44%
lib/stack/release
   index.js86.67%100.00%68.09%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/taxonomy
   index.js84.00%100.00%61.29%
lib/stack/taxonomy/terms
   index.js84.62%100.00%66.67%
lib/stack/variantGroup
   index.js81.58%100.00%60.47%
lib/stack/variantGroup/variants
   index.js77.50%100.00%54.90%
lib/stack/variants
   index.js76.32%100.00%53.19%
lib/stack/webhook
   index.js84.48%100.00%67.80%
lib/stack/workflow
   index.js83.64%100.00%67.69%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js91.43%100.00%78.57%

🤖 comment via lucassabreu/comment-coverage-clover

aman19K
aman19K reviewed Aug 12, 2025
View reviewed changes
@cs-raj cs-raj marked this pull request as ready for review August 12, 2025 07:19
@cs-raj cs-raj requested a review from a team as a code owner August 12, 2025 07:19
aman19K
aman19K previously approved these changes Aug 12, 2025
View reviewed changes
@cs-raj cs-raj requested a review from nadeem-cs August 12, 2025 08:03
@cs-raj cs-raj merged commit 5a5a7cc into development Aug 12, 2025
13 checks passed
@cs-raj cs-raj deleted the feat/DX-3418 branch August 12, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadeem-cs nadeem-cs nadeem-cs approved these changes

@aman19K aman19K aman19K left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cs-raj @nadeem-cs @aman19K