fix(react-native-windows): Fixed adding react-native-windows to a react-native project on a non-Windows platform. (microsoft#1162)

sayar · rozele · commit 7e16a1e833f3 · 2017-06-26T14:22:16.000Z
Adding react-native-windows to a react-native project through the `react-native windows` command would fail due to a dependency on a powershell script to generate a certificate. Temporarily using the default certificate that gets outputed if the powershell New-SelfSignedCertificate command fails.
diff --git a/local-cli/generator-windows/index.js b/local-cli/generator-windows/index.js
@@ -6,6 +6,8 @@ const fs = require('fs');
 const path = require('path');
 const uuid = require('uuid');
 const yeoman = require('yeoman-generator');
+const username = require('username');
+const os = require('os');
 
 const REACT_NATIVE_PACKAGE_JSON_PATH = function () {
   return path.resolve(
@@ -43,25 +45,32 @@ module.exports = yeoman.Base.extend({
   writing: function () {
     const projectGuid = uuid.v4();
     const packageGuid = uuid.v4();
-    const currentUser = childProcess.execSync('powershell $env:username')
+    const currentUser = username.sync(); // Gets the current username depending on the platform.
     const templateVars = { name: this.name, ns: this.options.ns, certificateThumbprint : null, projectGuid, packageGuid, currentUser };
 
-    const certGenCommand = [
-      `$cert = New-SelfSignedCertificate -KeyUsage DigitalSignature -KeyExportPolicy Exportable -Subject "CN=${currentUser}" -TextExtension @("2.5.29.37={text}1.3.6.1.5.5.7.3.3", "2.5.29.19={text}Subject Type:End Entity") -CertStoreLocation "Cert:\\CurrentUser\\My"`,
-      `$pwd = ConvertTo-SecureString -String password -Force -AsPlainText`,
-      `Export-PfxCertificate -Cert "cert:\\CurrentUser\\My\\$($cert.Thumbprint)" -FilePath ${path.join('windows', this.name, this.name)}_TemporaryKey.pfx -Password $pwd`,
-      `$cert.Thumbprint`
-    ];
-
     console.log(`Generating self-signed certificate...`);
-    const certGenProcess = childProcess.spawnSync('powershell', ['-command', certGenCommand.join(';')]);
-
-    if (certGenProcess.status === 0) {
-      const certGenProcessOutput = certGenProcess.stdout.toString().trim().split('\n');
-      templateVars.certificateThumbprint = certGenProcessOutput[certGenProcessOutput.length - 1];
-      console.log(chalk.green("Self-signed certificate generated successfully."));
+    if (os.platform() === 'win32') {
+      const certGenCommand = [
+        `$cert = New-SelfSignedCertificate -KeyUsage DigitalSignature -KeyExportPolicy Exportable -Subject "CN=${currentUser}" -TextExtension @("2.5.29.37={text}1.3.6.1.5.5.7.3.3", "2.5.29.19={text}Subject Type:End Entity") -CertStoreLocation "Cert:\\CurrentUser\\My"`,
+        `$pwd = ConvertTo-SecureString -String password -Force -AsPlainText`,
+        `Export-PfxCertificate -Cert "cert:\\CurrentUser\\My\\$($cert.Thumbprint)" -FilePath ${path.join('windows', this.name, this.name)}_TemporaryKey.pfx -Password $pwd`,
+        `$cert.Thumbprint`
+      ];
+      const certGenProcess = childProcess.spawnSync('powershell', ['-command', certGenCommand.join(';')]);
+
+      if (certGenProcess.status === 0) {
+        const certGenProcessOutput = certGenProcess.stdout.toString().trim().split('\n');
+        templateVars.certificateThumbprint = certGenProcessOutput[certGenProcessOutput.length - 1];
+        console.log(chalk.green("Self-signed certificate generated successfully."));
+      } else {
+        console.log(chalk.yellow('Failed to generate Self-signed certificate. Using Default Certificate. Use Visual Studio to renew it.'));
+        this.fs.copy(
+          this.templatePath(path.join('keys', 'MyApp_TemporaryKey.pfx')),
+          this.destinationPath(path.join('windows', this.name, this.name + '_TemporaryKey.pfx'))
+        );
+      }
     } else {
-      console.log(chalk.yellow('Failed to generate Self-signed certificate. Using Default Certificate. Use Visual Studio to renew it.'));
+      console.log(chalk.yellow('Using Default Certificate. Use Visual Studio to renew it.'));
       this.fs.copy(
         this.templatePath(path.join('keys', 'MyApp_TemporaryKey.pfx')),
         this.destinationPath(path.join('windows', this.name, this.name + '_TemporaryKey.pfx'))
diff --git a/package.json b/package.json
@@ -42,6 +42,7 @@
     "chalk": "^1.1.3",
     "glob": "^7.0.3",
     "shelljs": "^0.7.0",
+    "username": "^3.0.0",
     "uuid": "^2.0.1",
     "xml-parser": "^1.2.1",
     "yeoman-environment": "^1.5.3",
