Skip to content

fix(CDataTable): issue with loading and no-items-view slots #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix(CDataTable): issue with loading and no-items-view slots #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(CDataTable): fixed issue with loading/no-items-slot 
if loading the items in the table asynchronously and passing the loading
prop to the c-data-table, until the request would be done, the table
would display both the no-item-slot and the loading slot. this fix
changes it so that while loading, do not display the no-items-slot
  • Loading branch information
@alexraileanu
alexraileanu committed Mar 10, 2021
commit 91024bc759c9b0b17ab28dd2739bd9a2b1023db3
2 changes: 1 addition & 1 deletion src/components/table/CDataTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
</td>
</tr>
</template>
<tr v-if="!currentItems.length">
<tr v-if="!currentItems.length && !loading">
<td :colspan="colspan">
<slot name="no-items-view">
<div class="text-center my-5">
Expand Down