Skip to content

Upgrade ESLint to v9.x and update dependencies #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintignore

This file was deleted.

75 changes: 0 additions & 75 deletions .eslintrc.js

This file was deleted.

7 changes: 0 additions & 7 deletions .prettierrc.js

This file was deleted.

76 changes: 76 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
import eslint from '@eslint/js'
import eslintPluginUnicorn from 'eslint-plugin-unicorn'
import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'
import eslintPluginVue from 'eslint-plugin-vue'
import globals from 'globals'
import typescriptEslint from 'typescript-eslint'

export default typescriptEslint.config(
{ ignores: ['**/*.d.ts', '**/coverage', '**/dist', '**/docs'] },
{
extends: [
eslint.configs.recommended,
...typescriptEslint.configs.recommended,
...eslintPluginVue.configs['flat/recommended'],
eslintPluginUnicorn.configs['flat/recommended'],
],
files: ['packages/**/src/**/*.{js,ts,tsx}'],
languageOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
globals: globals.browser,
parserOptions: {
parser: typescriptEslint.parser,
},
},
rules: {
'no-console': 'off',
'no-debugger': 'off',
'unicorn/filename-case': 'off',
'unicorn/no-array-for-each': 'off',
'unicorn/no-null': 'off',
'unicorn/prefer-dom-node-append': 'off',
'unicorn/prefer-export-from': 'off',
'unicorn/prefer-query-selector': 'off',
'unicorn/prevent-abbreviations': 'off',
'vue/require-default-prop': 'off',
},
},
{
files: ['**/*.mjs'],
languageOptions: {
globals: {
...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
...globals.node,
},

ecmaVersion: 'latest',
sourceType: 'module',
},
},
{
files: ['**/__tests__/*.{j,t}s?(x)', '**/tests/unit/**/*.spec.{j,t}s?(x)'],
languageOptions: {
globals: {
...globals.jest,
},
},
},
{
files: ['packages/docs/build/**'],
languageOptions: {
globals: {
...Object.fromEntries(Object.entries(globals.browser).map(([key]) => [key, 'off'])),
...globals.node,
},

ecmaVersion: 5,
sourceType: 'commonjs',
},
rules: {
'no-console': 'off',
strict: 'error',
},
},
eslintPluginPrettierRecommended,
)
20 changes: 9 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,21 @@
"lib:build": "lerna run --scope \"@coreui/vue\" build --stream",
"lib:test": "lerna run --scope \"@coreui/vue\" test --stream",
"lib:test:update": "lerna run --scope \"@coreui/vue\" test:update --stream",
"lint": "eslint \"packages/**/src/**/*.{js,ts,tsx}\"",
"lint": "eslint",
"test": "npm-run-all charts:test icons:test lib:test",
"test:update": "npm-run-all charts:test:update icons:test:update lib:test:update"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^8.6.0",
"@typescript-eslint/parser": "^8.6.0",
"@vue/eslint-config-prettier": "^9.0.0",
"@vue/eslint-config-typescript": "^13.0.0",
"@vue/vue3-jest": "29.2.6",
"eslint": "8.57.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-vue": "^9.28.0",
"eslint": "^9.17.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-unicorn": "^55.0.0",
"lerna": "^8.1.8",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-unicorn": "^56.0.1",
"eslint-plugin-vue": "^9.32.0",
"globals": "^15.14.0",
"lerna": "^8.1.9",
"npm-run-all": "^4.1.5",
"prettier": "^3.3.3"
"prettier": "^3.4.2",
"typescript-eslint": "^8.19.1"
}
}
12 changes: 6 additions & 6 deletions packages/coreui-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,20 @@
"@popperjs/core": "^2.11.8"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^28.0.1",
"@rollup/plugin-node-resolve": "^15.3.0",
"@rollup/plugin-typescript": "^12.1.1",
"@rollup/plugin-commonjs": "^28.0.2",
"@rollup/plugin-node-resolve": "^16.0.0",
"@rollup/plugin-typescript": "^12.1.2",
"@types/jest": "^29.5.14",
"@vue/test-utils": "^2.4.6",
"@vue/vue3-jest": "29.2.6",
"cross-env": "^7.0.3",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
"rollup": "^4.24.2",
"rollup": "^4.30.1",
"rollup-plugin-vue": "^6.0.0",
"ts-jest": "^29.2.5",
"typescript": "^5.6.3",
"vue": "^3.5.12",
"typescript": "^5.7.2",
"vue": "^3.5.13",
"vue-types": "^5.1.3"
},
"peerDependencies": {
Expand Down
28 changes: 14 additions & 14 deletions packages/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,23 @@
"@coreui/icons-vue": "^2.2.0",
"@coreui/utils": "^2.0.2",
"@coreui/vue-chartjs": "^3.0.0",
"@docsearch/css": "^3.6.2",
"@docsearch/js": "^3.6.2",
"@vuepress/bundler-vite": "2.0.0-rc.18",
"@vuepress/bundler-webpack": "2.0.0-rc.18",
"@vuepress/plugin-active-header-links": "2.0.0-rc.55",
"@vuepress/plugin-git": "2.0.0-rc.56",
"@vuepress/plugin-markdown-container": "2.0.0-rc.54",
"@docsearch/css": "^3.8.2",
"@docsearch/js": "^3.8.2",
"@vuepress/bundler-vite": "2.0.0-rc.19",
"@vuepress/bundler-webpack": "2.0.0-rc.19",
"@vuepress/plugin-active-header-links": "2.0.0-rc.69",
"@vuepress/plugin-git": "2.0.0-rc.68",
"@vuepress/plugin-markdown-container": "2.0.0-rc.66",
"@vuepress/plugin-prismjs": "2.0.0-rc.37",
"@vuepress/plugin-theme-data": "2.0.0-rc.57",
"@vuepress/plugin-register-components": "2.0.0-rc.54",
"@vuepress/plugin-toc": "2.0.0-rc.55",
"@vuepress/shared": "2.0.0-rc.18",
"@vuepress/utils": "2.0.0-rc.18",
"@vuepress/plugin-theme-data": "2.0.0-rc.69",
"@vuepress/plugin-register-components": "2.0.0-rc.66",
"@vuepress/plugin-toc": "2.0.0-rc.66",
"@vuepress/shared": "2.0.0-rc.19",
"@vuepress/utils": "2.0.0-rc.19",
"markdown-it-anchor": "^9.2.0",
"markdown-it-include": "^2.0.0",
"sass": "^1.80.4",
"sass": "^1.83.1",
"vue-docgen-cli": "^4.79.0",
"vuepress": "2.0.0-rc.18"
"vuepress": "2.0.0-rc.19"
}
}
13 changes: 13 additions & 0 deletions prettier.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/**
* @see https://prettier.io/docs/en/configuration.html
* @type {import("prettier").Config}
*/
const config = {
printWidth: 100,
semi: false,
singleQuote: true,
tabWidth: 2,
trailingComma: 'es5',
};

export default config;