Skip to content

Conversation

dpdanpittman
Copy link
Contributor

Updated the file client.py for people to use in the ropsten network.

prefix constant in Client class changed to https://api-ropsten.etherscan.io/api?
readme was updated with https://ropsten.etherscan.io/apis for use with ropsten testnet
Copy link
Owner

@corpetty corpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the filename to not have .py.py and we can get this in there. Sorry for the late response.

@dpdanpittman
Copy link
Contributor Author

Fixed extension and pushed changes. Please pull. Thanks

@AndreMiras
Copy link
Contributor

Thanks for the pull request @dpdanpittman good start :)
I'm a curious why almost everything is written from scratch including exceptions rather than "simply" inheriting the existing from etherscan.client.Client and overriding PREFIX?

@corpetty corpetty merged commit 18ee101 into corpetty:master Sep 17, 2018
@AndreiShybin
Copy link

18ee101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants