Add more problems on binary search article #1147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (for commit ed007b9): https://cp-algorithms--preview-1147-r3yai8f2.web.app (expires 2023-09-19T14:14:10.371208251Z) |
jakobkogler
requested changes
Sep 24, 2023
There was a problem hiding this comment.
Hallo. Two problems with this Pull Request:
- We already have quite a lot of problems on this article. The goal here is not to have a gigantic list of all binary search problems, but a selection of good problems about a topic. Are these problems any good? And do they add something that the other problems don't teach yet?
- I've only opened two random links that you added. And both problems (CSES - Room Allocation and Codeforces - Prime Matrix) don't require binary search to solve them. I would even say that binary search will make the solution worse. So are these actually binary search problems?
|
As this is a stale Pull Request, I close it per Jakob's rationale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some problems that I think are helpful.