Made 1-based indexing as the main approach for fenwick tree #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Note: You didn't fix the part about the ranges, which is what makes the 1-indexing nicer. The ranges are now (g(i),i] instead of [g(i),i]. Please review it carefully. Also restore the 0-based indexing version somewhere for reference. |
|
Also the PR tests show that https://github.com/cp-algorithms/cp-algorithms/blob/main/test/test_fenwick_tree.cpp needs to be fixed, but I have never used the test runners before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1346
The code now focuses on easier to understand and intrepret 1-based indexing, sentences are also modified to indicate the main approach used here is one-based indexing.
Changed the FenwickTree for 1D, 2D array for sum and for minimum queries