Skip to content

Fix the remainder group size in binary grouping solution of the multiple knapsack problem #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

virinci
Copy link
Contributor

@virinci virinci commented Oct 31, 2024

The existing groups are: $2^0, 2^1, \dots, 2^{\lfloor \log_2(k+1) \rfloor - 1}$ and they sum up to $2^{\lfloor \log_2(k+1) \rfloor} - 1$. So, the remaining groups should be $k_i - sum$.

@mhayter
Copy link
Contributor

mhayter commented Nov 2, 2024

I think you're right! Good catch!

@mhayter mhayter merged commit efecea8 into cp-algorithms:main Nov 2, 2024
3 checks passed
github-actions bot added a commit that referenced this pull request Nov 2, 2024
@virinci virinci deleted the patch-1 branch November 7, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants