-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add virtual trees article and tests #1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your article! This is a little out of my expertise so I usually defer to more senior people for article publishing like @adamant-pwn or @jakobkogler. With that, in the next few days I hope to give you at least some feedback. For now, the README.md will need to be updated. |
Sure, glad to help! |
Some super quick feedback: Please add prerequisites with links to our articles if possible. This is an advanced topic so people who don't know binary lifting, dp, etc. don't really need to read this article. What is an induced graph? It's not defined and I've gone to university for CS and don't know lol. What is dfs order? Is it preorder, postorder, in order, level order? I'm not familiar with this term. The article is quite similar to the editorial for the stated problem on atcoder (https://atcoder.jp/contests/abc340/editorial/9256) Are you the author of the editorial or are you just slightly rewording things? At the very least, it seems significant credit and/or citation should be given I think. Question to @adamant-pwn :Is posting a problem and solving it so specifically allowed? A visual of what a virtual tree is or does would be nice. I'd prefer an original otherwise I do feel we're getting into the realm of just linking to the tutorial. I'm not sure we're using lambdas in C++ as they don't really carryover well with people who aren't familiar with them in other languages. How were these comments generated? Some of them feel like chatgpt. They sometimes describe very obvious things but aren't descriptive enough on what's happening. For instance, "// DP transitions: combining current state with result from subtree int nxt0 = (dp[v][0] + sum[to]) % MOD; This is is sort of obvious, but what isn't is why they're be in added in the way that they are. I'm also not sure why the 'ntx0' and 'nxt1' variables exist. Also would prefer 'col' to be 'color' and be consistent with underscore ( 'get_lca'). ****** Please make sure the code compiles some constants are not defined ****** Please add the update the README.md as well. More feedback will likely be coming. |
Surely, the prereqs will be added. |
I admire your honesty. With that said, are you the author of this article or is Nyaan and ChatGPT? Do you have permission from him? I'm not sure on the terms of service of atcoder is but it really seems like Nyaan should be submitting this article given is extreme similarity to the original editorial. |
I mean... in no way did I say this is my article or I'm the author. I just wanted to share it since it was posted on the free and open platform for everyone. This is why I wrote this is fork. Moreover, this is why I attached exactly that Atcoder problem for analysis. This is how I first learnt about this idea. |
Perhaps there's misunderstanding. Articles not translated from the original website are assumed to be written by the author. You will be credited on the website as an author (look at the bottom of the articles.) |
We have the text in the footer: "Text is available under the Creative Commons Attribution Share Alike 4.0 International License". Anything that is added to the website should generally conform to the license. With translations of e-maxx.ru it is OK because Maksim dedicated his articles to the public domain. For anything else, it must either be created by the person contributing the article, or the original content must be also licensed under CC BY-SA 4.0 or compatible license, and even then any contribution should be appropriately attributed to the original author in the text. |
ok sir |
@adamant-pwn So we can't cite problems that are public domain or CC license? |
We can't word-for-word copy them. Rewording in our terms is fine. Also when the material is very short and technical, it can be sometimes argued that it doesn't pass originality / creativity threshold and is thus not copyrightable. |
No description provided.