[Suggestion][Feedback Wanted] using cmake + google test for writing tests #1464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This is a draft suggestion PR to move to more industry-oriented approach for testing.
Suggested Changes:
test.sh
)cp-algorithms
tests at once.Side note: I was suspecting that there will be ODR violation error when including the same snippet in multiple source files, but it seems that we're good, since ODR is applicable only to a single translation unit.
Current Changes
extract_snippets.py
script (add logging and command line arguments support)test/
folder, suggested layout:Changes To Be Implemented If This Approach Is Approved
-fsanitize=undefined -fno-sanitize-recover
compiler flagstest_*.cpp
files to use google test framework#pragma once
to all generated snippetsQuestion to Maintainers
What are your thoughts on this? I'm down to rework all the test files, but would like to hear your feedback/suggestions first :)