Explanation about templates in the repo #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tcNickolas Hi! This PR is mainly to make sure you will notice this subtle change. The main idea is that now participants can propose (if there is utter necessity) changes to the template in this repo (previously this required re-uploading the whole app which only I was able to do, and I also didn't remember the process well).
Regretfully templates could not be tested (e.g. with test-your-page) beforehand by participants, so it's ok to merge them, and if anything is broken, revert back. %)
Though I hope it will not be very common :)
Respective change in e-maxx-eng-auto was merged here https://github.com/e-maxx-eng/e-maxx-eng-auto/pull/5 though I hope no one will need to bother with this nasty code