Skip to content

Credit Shamos for nearest pair of points algorithm #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

jxu
Copy link
Contributor

@jxu jxu commented Jan 6, 2023

Resolves #969

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Visit the preview URL for this PR (for commit 8602f42):

https://cp-algorithms--preview-998-tjb07as8.web.app

(expires 2023-01-13T04:03:11.399726505Z)

@adamant-pwn
Copy link
Member

Thanks! I think we should also add some reference to their specific publication that we mention here. And is it certain that we should only mention Shamos, but not Hoey?

@jxu
Copy link
Contributor Author

jxu commented Jan 6, 2023

I'm not sure who to credit. One publication is from Shamos, one from Shamos & Hoey. The textbook says the algorithm is due to Shamos.

@adamant-pwn
Copy link
Member

I've checked the publication by Shamos. The corresponding section in his article references the joint article with Hoey.

image

I think we should attribute both authors, and also put a link to the original article.

@adamant-pwn adamant-pwn merged commit 42c5856 into cp-algorithms:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Finding the nearest pair of points" Original paper
2 participants