Skip to content

N4944 pre-CD: Remaining inconsistent inline constexpr variable templates #6204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dani-Hub opened this issue Mar 23, 2023 · 8 comments
Closed

N4944 pre-CD: Remaining inconsistent inline constexpr variable templates #6204

Dani-Hub opened this issue Mar 23, 2023 · 8 comments

Comments

@Dani-Hub
Copy link
Member

After the recent adjustment to strike "inline" from constexpr variable templates, the following cases are still present (looking at the N4944 pre-CD working draft):

  1. [ranges.syn]:
namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent = unspecified; // freestanding
  [...]
}
[...]
namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent = unspecified; // freestanding
  [...]
}
[...]
namespace views {
  template<size_t N>
    inline constexpr unspecified adjacent_transform = unspecified; // freestanding
  [...]
}
  1. [range.refinements]:
template<class R>
  inline constexpr bool is-initializer-list = see below ; // exposition only
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 23, 2023

Thanks, I agree we should fix that. @jwakely, do you agree?

@jwakely
Copy link
Member

jwakely commented Mar 29, 2023

I agree.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 29, 2023 via email

@Dani-Hub
Copy link
Member Author

I can work on that.

Dani-Hub added a commit to Dani-Hub/draft that referenced this issue Mar 29, 2023
@Dani-Hub
cplusplus#6204 Remove remaining inline from variable templates
0dc45b2 
Signed-off-by: Daniel Krügler <daniel.kruegler@gmail.com>
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 29, 2023 via email

@frederick-vs-ja
Copy link
Contributor

This should have been fixed.

@AlisdairM
Copy link
Contributor

This was most recently addressed by #7240. Does that resolve this issue?

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 17, 2024

Looks like it, thanks!

@tkoeppe tkoeppe closed this as completed Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Dani-Hub @AlisdairM @jwakely @tkoeppe @frederick-vs-ja