[alg.min.max] Reword min/max/minmax in modern style #6776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is |
|
This doesn't exactly address #6747, which wants to replace "smaller" and "larger" with "lesser" and "greater". I want to get rid of the terms altogether and more directly explain what these algorithms do with a custom predicate and projection. In no way does (But yes - thanks - the issue and PR do seem to be at least related.) |
|
Right. Closes #6747.
Closes #6752. |
Quuxplusone
reviewed
Jan 19, 2024
... to clarify the meaning of "smaller"/"smallest"/"larger"/"largest" with a custom comparison predicate and/or projection.
|
@jwakely I'd welcome your LWG perspective if this is OK editorially. |
|
The contents of this PR are new the proposed resolution of LWG-4167. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to clarify the meaning of "smaller"/"smallest"/"larger"/"largest" with a custom comparison predicate and/or projection by effectively replacing those terms with code.
Closes #6747.
Closes #6752.