Skip to content

[macros,numerics] Add and use numbered 'formula' environment #7026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

[macros,numerics] Add and use numbered 'formula' environment #7026

merged 1 commit into from
Jul 10, 2024

Conversation

jensmaurer
Copy link
Member

Fixes ISO/CS comment (C++23 proof)

  • This is a formula which should be labelled Formula (1). See HYPERLINK "https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor410"ISO/IEC Directives Part 2, 2021, 27.4 "Please number mathematical formulae in the document, for cross-referencing purposes. Arabic numbers in parentheses shall be used, starting with 1. If a mathematical formula is numbered, it should also be referred to in the text and its purpose should be made clear by its context, for example, with an introductory proposition, e.g. "see 10.1, Formula (3)".
  • see comment above regarding Formulae
  • this appears to be a formulae - please follow the ISO/IEC Directives Part 2, Clause 27

@jensmaurer jensmaurer added the ballot-comment Response to an NB or ISO comment on a ballot label May 16, 2024
@jensmaurer jensmaurer added this to the C++23 milestone May 16, 2024
@tkoeppe
Copy link
Contributor

tkoeppe commented May 16, 2024

(Have you got a screenshot by any chance? :-) )

@jensmaurer
Copy link
Member Author

jensmaurer commented May 16, 2024 •
edited
Loading

image

image

@tkoeppe
Copy link
Contributor

tkoeppe commented May 16, 2024

Looks great, thanks!

tkoeppe
tkoeppe reviewed May 16, 2024
View reviewed changes
@jensmaurer
Copy link
Member Author

image

@jensmaurer
Copy link
Member Author

When we do this, we might replace the "k is k" stuff by directly putting in the monospace-font C++ variables into the "value", e.g. "Pi(nu, k)". What do you think?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 10, 2024

When we do this, we might replace the "k is k" stuff by directly putting in the monospace-font C++ variables into the "value", e.g. "Pi(nu, k)". What do you think?

This is something we've been wanting to do for a while, but this requires some thought. Let's do this for the WD only, and talk about it separately.

@jwakely ^^^ I think you had some thoughts here, too.

@tkoeppe tkoeppe self-requested a review July 10, 2024 00:29
tkoeppe
tkoeppe approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@tkoeppe tkoeppe merged commit 5508a00 into cplusplus:main Jul 10, 2024
2 checks passed
@jwakely
Copy link
Member

jwakely commented Jul 18, 2024

@jwakely ^^^ I think you had some thoughts here, too.

More than just thoughts, see #4295

@jensmaurer jensmaurer deleted the e30 branch July 28, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe approved these changes

Assignees
No one assigned
Labels
ballot-comment Response to an NB or ISO comment on a ballot
Projects
None yet
Milestone
C++23
Development

Successfully merging this pull request may close these issues.
3 participants
@jensmaurer @tkoeppe @jwakely