[class.mi] Define ambiguous/unambiguous base class #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
reviewed
Oct 16, 2024
Currently, terms ambiguous base class and unambiguous base class are used without clear definition. The intent seems already clear to me, but perhaps it would be better to properly define them. Co-authored-by: Casey Carter <cartec69@gmail.com>
e873b38 to
916422f
Compare
|
I appreciate the desire for a clear definition, but this seems borderline not editorial. Yes, we know what we mean, but creating new definitions should be CWG territory. Tagging as "cwg"; maybe this can be done in a light-weight Core review -- @jensmaurer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, terms ambiguous base class and unambiguous base class are used without clear definition. The intent seems already clear to me, but perhaps it would be better to properly define them.
Fixes #5173.