[unique.ptr.single] Align preconditions and postconditions with the guidelines #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uidelines According to https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#formatting-declarations-and-definitions, conditions should be expressed as `<expr> is true` instead of simply `<expr>`. It seems that `std::unique_ptr` specification does not comply with that. This PR updates all such places that I have spotted.
MikailBag
commented
Jun 22, 2025
| @@ -2549,8 +2549,8 @@ | |||
|
|
|||
| \pnum | |||
| \ensures | |||
| If \tcode{this != addressof(u)}, | |||
| \tcode{u.get() == nullptr}, | |||
| If \tcode{this != addressof(u)} is \tcode{true}, | |||
There was a problem hiding this comment.
Perhaps this (and similar condition below) should be inverted to \tcode{this == addressof(u)} is \tcode{false}.
I'm not sure which way is more readable
There was a problem hiding this comment.
I wonder whether we can simply say "this == addressof(u) || u.get() == nullptr is true".
There was a problem hiding this comment.
But there is also an else branch, so it will look like this:
* `this == addressof(u) || u.get() == nullptr` is `true`
* `this != addressof(u)` is `true` or `u.get()` is unchanged
Looks a bit too complex to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#formatting-declarations-and-definitions, conditions should be expressed as
<expr> is trueinstead of simply<expr>. It seems thatstd::unique_ptrspecification does not comply with that.This PR updates all such places that I have spotted.