Skip to content

optionally exclude suggestions in the PR review (using env var) #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2bndy5 opened this issue Feb 10, 2024 · 1 comment · Fixed by #68
Closed

optionally exclude suggestions in the PR review (using env var) #67

2bndy5 opened this issue Feb 10, 2024 · 1 comment · Fixed by #68

Comments

@2bndy5
Copy link
Contributor

2bndy5 commented Feb 10, 2024

As I typed that list of caveats, I thought that it might be desirable to have only the PR review's summary comment (with no suggestions shown in the diff). To do that, I would probably support a env var named CPP_LINTER_PR_REVIEW_NO_SUGGESTION. That should help reduce PR thread pollution.

Originally posted by @2bndy5 in cpp-linter/cpp-linter-action#182 (comment)

@2bndy5
Copy link
Contributor Author

2bndy5 commented Feb 10, 2024

I think CPP_LINTER_PR_REVIEW_SUMMARY_ONLY might be a better env var name. It would be used in workflows like so:

- uses: cpp-linter/cpp-linter-action@v2
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    CPP_LINTER_PR_REVIEW_SUMMARY_ONLY: true
  with:
    tidy-review: true

2bndy5 added a commit that referenced this issue Feb 10, 2024
resolves #67

This is intended to let users reduce comments posted in PR reviews.
2bndy5 added a commit that referenced this issue Feb 10, 2024
resolves #67

This is intended to let users reduce comments posted in PR reviews.
2bndy5 added a commit that referenced this issue Feb 11, 2024
resolves #67

This is intended to let users reduce comments posted in PR reviews.
2bndy5 added a commit that referenced this issue Feb 11, 2024
* allow PR review summary without suggestions
  resolves #67
  This is intended to let users reduce comments posted in PR reviews.
* add test condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant