Skip to content

addresses #10 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

addresses #10 #11

merged 1 commit into from
Sep 16, 2022

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Sep 16, 2022

clang-tidy analyses the whole file if there is no diff info for the file

This means the annotations & comments will be unfiltered - even if the lines-changed-only option is enabled but only when there is no diff for the file.

clang-tidy analyses the whole file if there is no diff info for the file

This means the annotations & comments will be unfiltered - even if the
lines-changed-only option is enabled but only when
there is no diff for the file.
@2bndy5 2bndy5 linked an issue Sep 16, 2022 that may be closed by this pull request
@2bndy5 2bndy5 added the bug Something isn't working label Sep 16, 2022
@2bndy5 2bndy5 requested a review from shenxianpeng September 16, 2022 10:24
Copy link
Contributor

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2bndy5 2bndy5 merged commit a23e14d into main Sep 16, 2022
@2bndy5 2bndy5 deleted the compensate-for-missing-patch-info branch September 16, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line filtering error on large patches
2 participants