cpp_linter/clang_tools/clang_tidy.py (1)

285-285: Use write() instead of writelines() for writing byte content

Since original_buf is a bytes object containing the entire file content, using src.write(original_buf) is more appropriate than src.writelines([original_buf]), which is intended for writing a list of lines.

Apply this diff:

-src.writelines([original_buf])
+src.write(original_buf)

Configuration used: CodeRabbit UI
Review profile: CHILL

cpp_linter/clang_tools/clang_tidy.py (1)

273-274: Optimize busy-wait loops to reduce CPU usage.

The current implementation uses busy-wait loops that could consume unnecessary CPU cycles. Consider adding a small sleep to reduce CPU usage.

-                    while not src.readable() and time.monotonic_ns() < read_timeout:
-                        pass  # pragma: no cover
+                    while not src.readable() and time.monotonic_ns() < read_timeout:
+                        time.sleep(0.01)  # pragma: no cover
-                    while not src.writable() and time.monotonic_ns() < write_timeout:
-                        pass  # pragma: no cover
+                    while not src.writable() and time.monotonic_ns() < write_timeout:
+                        time.sleep(0.01)  # pragma: no cover

Also applies to: 282-283

Configuration used: CodeRabbit UI
Review profile: CHILL

cpp_linter/clang_tools/clang_tidy.py (1)

264-299: Consider extracting file operations into helper functions.

The current implementation has complex nested structures. Consider extracting the file operations into helper functions to improve readability and maintainability.

Here's a suggested refactoring:

def _wait_for_file_operation(timeout_ns: int, check_fn) -> bool:
    while time.monotonic_ns() < timeout_ns:
        if check_fn():
            return True
    return False

def write_back_original_content(filename: str, original_buf: bytes, advice: TidyAdvice) -> bool:
    timeout = time.monotonic_ns() + 1_000_000_000
    try:
        with open(filename, "r+b") as src:
            if not _wait_for_file_operation(
                time.monotonic_ns() + 1_000_000_000,
                lambda: src.readable()
            ):
                return False
            
            advice.patched = b"".join(src.readlines())
            src.seek(0)
            
            if not _wait_for_file_operation(
                time.monotonic_ns() + 1_000_000_000,
                lambda: src.writable()
            ):
                return False
                
            src.write(original_buf)
            return True
    except OSError as exc:
        logger.error(
            "Failed to write back contents of file: %s. %s",
            filename,
            f"{exc.__class__.__name__}: {', '.join(exc.args)}",
        )
        return False

# Usage in run_clang_tidy:
if tidy_review:
    original_buf = Path(filename).read_bytes()
    cmds.append("--fix-errors")
    # ... rest of the code ...
    if not write_back_original_content(filename, original_buf, advice):
        logger.error("Failed to write back contents of file: %s. timeout.", filename)

Configuration used: CodeRabbit UI
Review profile: CHILL

-        original_buf = Path(filename).read_bytes()
+        timeout = time.monotonic_ns() + 1_000_000_000
+        success = False
+        exception = None
+        while not success and time.monotonic_ns() < timeout:
+            try:
+                original_buf = Path(filename).read_bytes()
+                success = True
+            except OSError as exc:
+                exception = exc
+        if not success:
+            error_msg = " timeout." if not exception else f" {exception.__class__.__name__}: {', '.join(exception.args)}"
+            logger.error("Failed to read contents of file: %s.%s", filename, error_msg)
+            return advice