Skip to content

Hide or reuse PR reviews #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Hide or reuse PR reviews #135

wants to merge 37 commits into from

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Dec 18, 2024 •
edited
Loading

This is an upstream continuation from #131 with a focus on rewriting the PR review tests.

maoliver-amd and others added 30 commits December 18, 2024 12:56
@maoliver-amd @2bndy5
Add reuse/deletion of existing review comments
e9d7252
@maoliver-amd @2bndy5
Add options for controlling review comment reuse/deletion.
c96c375
@maoliver-amd @2bndy5
Update review comment CLI options.
9f15407
@maoliver-amd @2bndy5
Remove unused imports.
63bad77
@maoliver-amd @2bndy5
Apply suggestions from code review
dd8eb38 
Co-authored-by: Brendan <2bndy5@gmail.com>
@maoliver-amd @2bndy5
Use get instead of inline conditionals.
c6e2d19
@maoliver-amd @2bndy5
Reformat code.
d991263
@maoliver-amd @2bndy5
Make graphQL queries constants.
263fa86
@maoliver-amd @2bndy5
Use self.api for graphql
8d63b68
@maoliver-amd @2bndy5
Set delete_comment default to False.
a7b0f34 
Co-authored-by: Brendan <2bndy5@gmail.com>
@maoliver-amd @2bndy5
Rename variables to match CLI option names.
8239d32
@maoliver-amd @2bndy5
Simplify retrieving line_start/line_end from graphql response.
c6348f5
@maoliver-amd @2bndy5
Fix line_start and line_end
2b73f2c
@maoliver-amd @2bndy5
Improve review thread comment log output.
62f62fe
@maoliver-amd @2bndy5
Add graphql mock responses.
687772e
@maoliver-amd @2bndy5
Fix id tag naming.
b1122f6
@maoliver-amd @2bndy5
Apply suggestions from code review
e7f13f7 
Co-authored-by: Brendan <2bndy5@gmail.com>
@maoliver-amd @coderabbitai @2bndy5
Apply suggestions from code review
20e3d65 
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Brendan <2bndy5@gmail.com>
@maoliver-amd @2bndy5
Formatting cleanups.
e9abe5c
@maoliver-amd @2bndy5
Improve qraphQL query error detection.
e978e70
@maoliver-amd @2bndy5
Remove unused graphql author field
b0a9bd6
@2bndy5
code review
dfb80f3 
clean up and various fixes
@maoliver-amd @2bndy5
Dont dismiss ignored reviews.
70294ed
@maoliver-amd @2bndy5
Correct output concern count
20a541e
@maoliver-amd @2bndy5
Add default argument to _dismiss_stale_reviews.
ea6c5d1
@maoliver-amd @2bndy5
Extract _check_reused_comments into standalone function.
3ca65bf
@maoliver-amd @2bndy5
Fix incorrect comment check.
b244350
@maoliver-amd @2bndy5
Update _close_review_comment log.
d0a9e47
@maoliver-amd @2bndy5
Fix _dismiss_stale_reviews default argument to None.
83ff91e
@maoliver-amd @2bndy5
Apply suggestions from code review
c56813c 
Co-authored-by: Brendan <2bndy5@gmail.com>
@2bndy5 2bndy5 changed the title Hide reuse PR reviews Hide or reuse PR reviews Dec 18, 2024
@2bndy5 2bndy5 force-pushed the hide-reuse-pr-reviews branch from 8fd3b39 to e5f3482 Compare December 18, 2024 23:28
@2bndy5 2bndy5 marked this pull request as draft December 18, 2024 23:31
@2bndy5 2bndy5 added the enhancement New feature or request label Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.23392% with 68 lines in your changes missing coverage. Please review.

Project coverage is 96.64%. Comparing base (239d6b8) to head (822a845).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cpp_linter/rest_api/github_api.py 62.26% 40 Missing ⚠️
cpp_linter/clang_tools/patcher.py 31.57% 26 Missing ⚠️
tests/reviews/test_pr_review.py 92.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              main     #135      +/-   ##
===========================================
- Coverage   100.00%   96.64%   -3.36%     
===========================================
  Files           24       24              
  Lines         1869     2027     +158     
===========================================
+ Hits          1869     1959      +90     
- Misses           0       68      +68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5 2bndy5 force-pushed the hide-reuse-pr-reviews branch 4 times, most recently from d411d65 to 0768101 Compare December 23, 2024 05:59
@2bndy5 2bndy5 mentioned this pull request Dec 23, 2024
Draft
@2bndy5 2bndy5 force-pushed the hide-reuse-pr-reviews branch from 0768101 to 822a845 Compare December 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2bndy5 @maoliver-amd