Replace deprecated classifier with licence expression (PEP 639) #136
Conversation
WalkthroughThe pull request updates the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (55)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Build Docs
pyproject.toml
[error] 1-1: invalid pyproject.toml config: project.license. configuration error: project.license must be valid exactly by one definition (2 matches found): 'file' or 'text' must be specified.
🪛 GitHub Actions: Build and Test
pyproject.toml
[error] 1-1: Invalid pyproject.toml config: project.license must be valid exactly by one definition. Provide either 'file' or 'text' for the license.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
|
It seems setuptools not support PEP 639 yet pypa/setuptools#4629 : D |
|
Seems the pypa/gh-action-pypi-publish now supports this via twine v6.1.0 (see pypa/gh-action-pypi-publish#327). No progress on setuptools side though. |
|
I just ran into this deprecation warning on a separate C++ project's python bindings (that I maintain). Here's my current findings:
So, this can be merged if we update the build backend to use Line 2 in 41c7323 Note, this package's minimum supported python version is already v3.9+: Line 15 in 41c7323 So no loss of compatibility there. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1869 1869
=========================================
Hits 1869 1869 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Brendan <2bndy5@gmail.com>
|
Line 2 in 41c7323
Should we update setuptools version here to |
Any version before v77.0.0 would fail to install with these changes. It must be I only mention the other versions because the other C++ project I'm building for pypi still supports python v3.7 and v3.8 (for now). So, PEP639 cannot be applied to builds for python v3.7 or v3.8. |
Summary by CodeRabbit