feat: add ci section and bump pre-commit hooks #140
Conversation
WalkthroughThe Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.pre-commit-config.yaml(3 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.pre-commit-config.yaml
[error] 1-1: trailing spaces
(trailing-spaces)
🔇 Additional comments (3)
.pre-commit-config.yaml (3)
28-28:❓ Verification inconclusive
Check
mirrors-mypyupgrade to v1.15.0.Bumping your MyPy mirror to v1.15.0 can tighten type checks. Please re-run type checking and address any new errors, especially around third-party stubs (
types-requests,rich, etc.).
🏁 Script executed:
#!/bin/bash # Run MyPy to detect any new type errors mypy .Length of output: 103
Verify MyPy mirror upgrade to v1.15.0
The sandbox couldn’t run MyPy (
mypy: command not found), so we couldn’t confirm whether the bump tov1.15.0introduces new errors. Please:
- Ensure MyPy is installed in your environment (e.g. activate your venv or run
pip install -r requirements-dev.txt).- Re-run type checking against the full codebase.
- Address any new errors, particularly in third-party stubs (
types-requests,rich, etc.).- Confirm all type checks pass before merging.
39-39:❓ Verification inconclusive
Validate cspell-cli update to v9.0.1.
Ensure the spelling dictionary and command-line interface haven't changed flags or default behaviors in v9.x. Run cspell on your docs/tests to confirm no regressions.
🏁 Script executed:
#!/bin/bash # Spell-check the repository to catch any new issues cspell --no-progress .Length of output: 121
Verify cspell-cli v9.0.1 update
Ensure the CLI install and invocation still work and haven’t introduced any breaking changes to flags or defaults. For example, install and run:
npm install cspell-cli@9.0.1 --no-save npx cspell --no-progress .Confirm no new spelling errors are reported across docs/tests and adjust the command if any flags or defaults have changed.
21-21:❓ Verification inconclusive
Verify Ruff pre-commit bump to v0.11.10.
Upgrading
astral-sh/ruff-pre-commitfrom v0.6.4 to v0.11.10 may introduce new lint rules or change defaults. Run your full test suite and inspect diagnostics to ensure no unexpected failures.
🏁 Script executed:
#!/bin/bash # Run ruff against the codebase to catch any new lint errors ruff --exit-zero .Length of output: 137
🏁 Script executed:
#!/bin/bash # Display available commands and options for Ruff ruff --help # Test running Ruff check with --exit-zero flag ruff check . --exit-zeroLength of output: 1750
Ruff pre-commit bump to v0.11.10: lint clean but please run full test suite
Running the correct lint command shows no new diagnostics:
ruff check . --exit-zero # → All checks passed!Please also run your full test suite to ensure there are no unexpected failures before merging.
|
This isn't an enhancement really. It is more like a chore. And I don't see a new "CI section". I think the title could be
|
|
That's a good idea. The reason the CI is failing is because one of the coverage data files uses absolute paths even though it is supposed to use relative paths. I've seen this error before v7.8, but usually I was able to fix it by re-running all the jobs in the test CI. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1869 1869
=========================================
Hits 1869 1869 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Coverage report still failing after this PR merged into the main branch https://github.com/cpp-linter/cpp-linter/actions/runs/15131437255/job/42590531046 |
|
Yep. It is an infrequent error in I don't remember if this happened before we merged #92. Whenever it does happen, I found that just re-running all jobs would fix it (eventually, may take more than 1 re-run). It is weird that the error happens more often now; last year, it only happened rarely. |
|
I think we could instead upload multiple reports to codecov, but that is not a simple patch. |
Summary by CodeRabbit