Skip to content

check dict key before using it #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

check dict key before using it #17

merged 1 commit into from
Nov 8, 2022

Conversation

shenxianpeng
Copy link
Contributor

Fix #16

@shenxianpeng shenxianpeng marked this pull request as draft November 7, 2022 09:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shenxianpeng shenxianpeng marked this pull request as ready for review November 7, 2022 09:28
@shenxianpeng shenxianpeng requested a review from 2bndy5 November 7, 2022 09:28
@shenxianpeng shenxianpeng mentioned this pull request Nov 7, 2022
Closed
@2bndy5
Copy link
Contributor

2bndy5 commented Nov 7, 2022

Its weird that code coverage report wasn't commented. Even weirder that codecov.io is saying the "No Files covered by tests were changed"

@shenxianpeng
Copy link
Contributor Author

Yes, it's weird. (maybe I git push force in this PR 😢). I'm going to merge it and create another release.

@shenxianpeng shenxianpeng merged commit 230f2f3 into main Nov 8, 2022
@shenxianpeng shenxianpeng deleted the check-dict-key branch November 8, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpp-linter performing checkup on a new .c file failed
2 participants
@shenxianpeng @2bndy5