-
-
Notifications
You must be signed in to change notification settings - Fork 8
Skip file when no new lines added and lines-changed-only is asserted #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 80.68% 81.51% +0.82%
==========================================
Files 6 6
Lines 647 649 +2
==========================================
+ Hits 522 529 +7
+ Misses 125 120 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The solution for this is going to need more than just a few lines changed. I'll start hacking it... |
properly resolves #18
This branch is now overwritten by my changes to properly address #18. |
also improve unit tests about lines-changed-only
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good to me. 👏
The unit tests agree with you. If released, this would be a patch version bump. I'm ready when you are. |
I'm ready, let me test it in action after release. |
FYI, I added your p_enemy.c file to the unit test for precision. |
So I need to keep p_enemy.c file always in the test-repo? at least I need to keep test-repo always existing, I think I will not delete it. |
I'm going to merge this pull request. |
You shouldn't need to since the file's "added" state is specific to the commit that was pushed to the remote. I don't think GitHub deletes orphaned branches/commits. |
We could always change the file to a new file in this repo's demo src. Ironically, the name p_enemy.c is also used in chocolate-doom (which we also use in the unit test), but there's no conflict because chocolate-doom's file is located in src/hexen/p_enemy.c (your file is in the supposed repo-root). |
I think the current change can stop adding
--line-filter
arg in clang-tidy whenlines
is empty.But to skip adding annotation for such situation (only delete code), I guess need to change func
range_of_changed_lines
to get an empty list, but I am not sure how to change it. @2bndy5 could you help when you have time?cpp-linter/cpp_linter/run.py
Line 890 in f53976a
I used this test job to reproduce #18